NETOBSERV-2126: reintroduce merge option, and cleanup old dedup code #775
Conversation
|
@jotak: This pull request references NETOBSERV-2126 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jotak
force-pushed
the
merge-option
branch
2 times, most recently
from
1af3115 to
4eb04a0
Compare
jotak
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=a89325d make set-plugin-image |
jotak
changed the title
| <div className="pf-v5-c-menu__group"> | ||
| <Tooltip | ||
| content={t( | ||
| // eslint-disable-next-line max-len | ||
| 'A flow might be reported from several interfaces, and from both source and destination nodes, making it appear several times. By default, duplicates are hidden. Showing duplicates is not possible in Overview and Topology tabs to avoid altering metric calculations. Use the Direction filter to switch between ingress, egress and inner-node traffic.' | ||
| )} | ||
| > | ||
| <div className="pf-v5-c-menu__group-title"> | ||
| <Text component={TextVariants.p}> | ||
| {t('Duplicated flows')} <InfoAltIcon /> | ||
| </Text> | ||
| </div> | ||
| </Tooltip> | ||
| <label className="display-dropdown-padding pf-v5-c-menu__menu-item"> | ||
| <Checkbox | ||
| isChecked={allowShowDuplicates ? showDuplicates : false} | ||
| isDisabled={!allowShowDuplicates} | ||
| name={'show-duplicates'} | ||
| onChange={() => setShowDuplicates(!showDuplicates)} | ||
| label={t('Show duplicates')} | ||
| data-test={'show-duplicates'} | ||
| id={'show-duplicates'} | ||
| /> | ||
| </label> | ||
| </div> |
There was a problem hiding this comment.
Should we keep that in the query options or move it in the table display options ?
github-actions
bot
removed
the
ok-to-test
|
@jotak: This pull request references NETOBSERV-2126 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jotak
added
the
ok-to-test
|
@jotak: This pull request references NETOBSERV-2126 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=734672d make set-plugin-image |
|
/retest |
Amoghrd
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=71317bb make set-plugin-image |
|
@jotak: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label qe-approved |
|
@jotak: This pull request references NETOBSERV-2126 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…775) * NETOBSERV-2126: reintroduce merge option, and cleanup old duplicate code * Move 'show duplicates' from query opts to display opts
4 participants
Description
The only visible change here is the "show duplicates" checkbox that is now always displayed (previously it was only visible when
deduper.markwas configured in advanced options). Also, it is moved from the Query options dropwdown to the Display options, only in the "Traffic flows" view.There's also a lot of cleanup here due to agent dedup not being configurable anymore since 1.8 (no more mark/merge, it's always merge)
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.